chore: adding support for x86_64-darwin #1310
Conversation
It does help us to run these builds/checks. Usually a true full build only happens when something has changed in the source, otherwise it is passed over. Then, when some source is changed, the build for that part will happen, the results will be cached into our binary cache, and so then 90% of the rest of the future ci runs will be able to deterministically refer to and use the cached version. In the case of this build, adding a new system did trigger a full build, but that is also what we needed to test, and achieve. So it is typical practice in nix based systems to run both builds and checks like this in ci. It should actually trigger a full build only in the small minority of cases. And in those cases, you almost always want to test the build, and cache it if it succeeds. |
* chore: adding support for x86_64-darwin * fix: handle logic for various darwin platforms * fix: != &&, == || * fix: support system here too * feature: support added for x86_64-darwin * fix: increase timeout so that aws access does not expire * fix: duration was too high * chore: see if 2 hours will work * fix: try more than 2 less than 3 hrs * chore: try a bit lower * chore: bump down lower * chore: set to the apparent max * chore: limit nix build to 15 on x86_64-darwin --------- Co-authored-by: Sam Rose <[email protected]>
What kind of change does this PR introduce?
Minimum basis for supporting x86_64-darwin build